Paddy
3ea9e630ed
Prep PR for the admin auth module (docs/plan-admin-auth.md step 1).
better-auth 1.7 ships ESM only, so the API moves off CommonJS:
- "type": "module", module nodenext, target ES2024, .js suffixes on all
relative imports, require('mariadb'|'cors') replaced by imports, and
export= packages (winston, app-root-path, bcrypt) consumed via default
imports. The logger now uses appRoot.path explicitly.
- TypeScript 5.9, @types/node 26, tslint removed. Node 26 pinned via
engines and .nvmrc (Plesk runs 26).
- Jest 28 + ts-jest replaced by vitest 5. Eight test files depend on
hoisted module mocks with static imports and resetModules + require,
which Jest's ESM mode does not support; vitest keeps them nearly
verbatim. Coverage via @vitest/coverage-v8 (lcov), Sonar generic report
via vitest-sonar-reporter, so sonar-project.properties is unchanged.
vitest.config.ts sets FEEDBACK_IP_SALT so the suite passes without a
local .env.
- dotenv 8 -> 16 and axios 0.24 -> 1.x: their old typings are not
resolvable under nodenext.
- autoCommit: false dropped from the pool configs; it is not a mariadb
connector option and was silently ignored.
tsc clean, 96/96 tests green, compiled app boots and serves /, /docs and
CORS under Node ESM.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
60 lines
2.0 KiB
TypeScript
60 lines
2.0 KiB
TypeScript
import {describe, it, expect} from 'vitest';
|
|
import {escapeCsvField} from '../../src/models/feedback/admin/csv.service.js';
|
|
import {formatDatetime} from '../../src/models/feedback/feedback.dates.js';
|
|
|
|
describe('escapeCsvField', () => {
|
|
it('passes plain text through unchanged', () => {
|
|
expect(escapeCsvField('Abendlied')).toBe('Abendlied');
|
|
});
|
|
|
|
it('converts null/undefined to an empty string', () => {
|
|
expect(escapeCsvField(null)).toBe('');
|
|
expect(escapeCsvField(undefined)).toBe('');
|
|
});
|
|
|
|
it('converts numbers to strings', () => {
|
|
expect(escapeCsvField(5)).toBe('5');
|
|
});
|
|
|
|
it('quotes and doubles internal quotes (RFC 4180)', () => {
|
|
expect(escapeCsvField('Sie sagte "Danke"')).toBe('"Sie sagte ""Danke"""');
|
|
});
|
|
|
|
it('quotes a field containing the ; separator', () => {
|
|
expect(escapeCsvField('Rheinberger; Bach')).toBe('"Rheinberger; Bach"');
|
|
});
|
|
|
|
it('strips embedded newlines instead of breaking the row', () => {
|
|
expect(escapeCsvField('Zeile 1\r\nZeile 2')).toBe('Zeile 1 Zeile 2');
|
|
expect(escapeCsvField('Zeile 1\nZeile 2')).toBe('Zeile 1 Zeile 2');
|
|
});
|
|
|
|
it('prefixes formula-injection characters with an apostrophe', () => {
|
|
expect(escapeCsvField('=1+1')).toBe("'=1+1");
|
|
expect(escapeCsvField('+SUM(A1)')).toBe("'+SUM(A1)");
|
|
expect(escapeCsvField('-2')).toBe("'-2");
|
|
expect(escapeCsvField('@example')).toBe("'@example");
|
|
});
|
|
|
|
it('does not treat a mid-string = as formula injection', () => {
|
|
expect(escapeCsvField('x = y')).toBe('x = y');
|
|
});
|
|
});
|
|
|
|
describe('formatDatetime', () => {
|
|
it('formats a Date as YYYY-MM-DD HH:mm:ss, not the verbose Date.toString()', () => {
|
|
const d = new Date(2026, 7, 2, 21, 59, 21); // month is 0-indexed: August
|
|
expect(formatDatetime(d)).toBe('2026-08-02 21:59:21');
|
|
expect(formatDatetime(d)).not.toContain('GMT');
|
|
});
|
|
|
|
it('pads single-digit components', () => {
|
|
const d = new Date(2026, 0, 5, 3, 4, 5);
|
|
expect(formatDatetime(d)).toBe('2026-01-05 03:04:05');
|
|
});
|
|
|
|
it('returns an empty string for null', () => {
|
|
expect(formatDatetime(null)).toBe('');
|
|
});
|
|
});
|