Paddy
17ca6399e0
New /feedback API domain backed by its own FEEDBACK_DB, mirroring the Calendar domain's router -> service -> DB pool layering: - Public endpoints (no auth): eligible-events listing, event config, submission with honeypot + rate limiting (in-memory + DB backstop). - Admin endpoints (session-header auth, reusing Calendar's users/sessions via a swappable feedback.auth.ts boundary): events/songs/questions CRUD, bulk reorder/assignment, aggregated reporting, CSV export. - Schema in sql/feedback/001_init.sql (8 tables), applied and verified against the real FEEDBACK_DB. - 64 Jest tests covering validation, auth, rate limiting, CSV escaping, and report aggregation (pure functions, no DB needed). Includes fixes from a security review: path traversal defense doesn't apply here (that's the frontend proxy, separate repo), but the rate-limiter cluster does - recordSubmission now counts every processed request (not just successful ones), the in-memory Map evicts empty entries instead of growing unbounded, FEEDBACK_IP_SALT is required at boot instead of silently degrading to unsalted hashing, and submission answer/rating arrays are capped and de-duplicated to bound insert amplification. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
29 lines
1.1 KiB
TypeScript
29 lines
1.1 KiB
TypeScript
// Isolated from ratelimit.test.ts because it needs to control whether
|
|
// FEEDBACK_IP_SALT is present at module-load time, which a real dotenv.config()
|
|
// call would silently repopulate from the repo's .env file.
|
|
jest.mock('dotenv', () => ({config: jest.fn()}));
|
|
jest.mock('../../src/models/feedback/Feedback.db', () => ({
|
|
NachklangFeedbackDB: {getConnection: jest.fn()}
|
|
}));
|
|
|
|
describe('FEEDBACK_IP_SALT enforcement', () => {
|
|
const originalSalt = process.env.FEEDBACK_IP_SALT;
|
|
|
|
afterEach(() => {
|
|
process.env.FEEDBACK_IP_SALT = originalSalt;
|
|
jest.resetModules();
|
|
});
|
|
|
|
it('throws at import time when FEEDBACK_IP_SALT is unset, rather than silently hashing unsalted', () => {
|
|
jest.resetModules();
|
|
delete process.env.FEEDBACK_IP_SALT;
|
|
expect(() => require('../../src/models/feedback/feedback.ratelimit')).toThrow(/FEEDBACK_IP_SALT/);
|
|
});
|
|
|
|
it('does not throw when FEEDBACK_IP_SALT is set', () => {
|
|
jest.resetModules();
|
|
process.env.FEEDBACK_IP_SALT = 'a-real-salt';
|
|
expect(() => require('../../src/models/feedback/feedback.ratelimit')).not.toThrow();
|
|
});
|
|
});
|