From 84aaa9ed99ba3f14932876f473d2e439a9e537b9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Patrick=20M=C3=BCller?= <patrick@mueller-patrick.tech>
Date: Sun, 3 Oct 2021 11:34:54 +0200
Subject: [PATCH] Removing unused component, UI optimization

---
 Frontend/src/app/app.module.ts                |  2 --
 .../components/change/change.component.css    |  0
 .../components/change/change.component.html   |  1 -
 .../change/change.component.spec.ts           | 25 -------------------
 .../app/components/change/change.component.ts | 16 ------------
 .../event-detail/event-detail.component.html  |  1 +
 .../event-detail/event-detail.component.ts    | 19 ++++++--------
 7 files changed, 9 insertions(+), 55 deletions(-)
 delete mode 100644 Frontend/src/app/components/change/change.component.css
 delete mode 100644 Frontend/src/app/components/change/change.component.html
 delete mode 100644 Frontend/src/app/components/change/change.component.spec.ts
 delete mode 100644 Frontend/src/app/components/change/change.component.ts

diff --git a/Frontend/src/app/app.module.ts b/Frontend/src/app/app.module.ts
index 3104fa5..14fba11 100644
--- a/Frontend/src/app/app.module.ts
+++ b/Frontend/src/app/app.module.ts
@@ -9,7 +9,6 @@ import {PageNotFoundComponent} from './pages/page-not-found/page-not-found.compo
 import {WeekComponent} from './components/week/week.component';
 import {DayComponent} from './components/day/day.component';
 import {EventComponent} from './components/event/event.component';
-import {ChangeComponent} from './components/change/change.component';
 import {DatepickerComponent} from './components/datepicker/datepicker.component';
 import {EventDetailComponent} from './components/event-detail/event-detail.component';
 import {HttpClientModule} from '@angular/common/http';
@@ -27,7 +26,6 @@ import {BrowserAnimationsModule} from '@angular/platform-browser/animations';
         WeekComponent,
         DayComponent,
         EventComponent,
-        ChangeComponent,
         DatepickerComponent,
         EventDetailComponent
     ],
diff --git a/Frontend/src/app/components/change/change.component.css b/Frontend/src/app/components/change/change.component.css
deleted file mode 100644
index e69de29..0000000
diff --git a/Frontend/src/app/components/change/change.component.html b/Frontend/src/app/components/change/change.component.html
deleted file mode 100644
index 9cdace0..0000000
--- a/Frontend/src/app/components/change/change.component.html
+++ /dev/null
@@ -1 +0,0 @@
-<p>Change details</p>
diff --git a/Frontend/src/app/components/change/change.component.spec.ts b/Frontend/src/app/components/change/change.component.spec.ts
deleted file mode 100644
index db0e9ae..0000000
--- a/Frontend/src/app/components/change/change.component.spec.ts
+++ /dev/null
@@ -1,25 +0,0 @@
-import {ComponentFixture, TestBed} from '@angular/core/testing';
-
-import {ChangeComponent} from './change.component';
-
-describe('ChangeComponent', () => {
-    let component: ChangeComponent;
-    let fixture: ComponentFixture<ChangeComponent>;
-
-    beforeEach(async () => {
-        await TestBed.configureTestingModule({
-            declarations: [ChangeComponent]
-        })
-            .compileComponents();
-    });
-
-    beforeEach(() => {
-        fixture = TestBed.createComponent(ChangeComponent);
-        component = fixture.componentInstance;
-        fixture.detectChanges();
-    });
-
-    it('should create', () => {
-        expect(component).toBeTruthy();
-    });
-});
diff --git a/Frontend/src/app/components/change/change.component.ts b/Frontend/src/app/components/change/change.component.ts
deleted file mode 100644
index b9a77a4..0000000
--- a/Frontend/src/app/components/change/change.component.ts
+++ /dev/null
@@ -1,16 +0,0 @@
-import {Component, OnInit} from '@angular/core';
-
-@Component({
-    selector: 'app-change',
-    templateUrl: './change.component.html',
-    styleUrls: ['./change.component.css']
-})
-export class ChangeComponent implements OnInit {
-
-    constructor() {
-    }
-
-    ngOnInit(): void {
-    }
-
-}
diff --git a/Frontend/src/app/components/event-detail/event-detail.component.html b/Frontend/src/app/components/event-detail/event-detail.component.html
index caefda4..2304f16 100644
--- a/Frontend/src/app/components/event-detail/event-detail.component.html
+++ b/Frontend/src/app/components/event-detail/event-detail.component.html
@@ -56,6 +56,7 @@
                 <td class="change-summary">{{change.summary}}</td>
             </tr>
             <tr *ngIf="change.hasDetails">
+                <td></td>
                 <td class="change-old-version">{{change.oldVersion}}</td>
                 <td>--></td>
                 <td class="change-new-version">{{change.newVersion}}</td>
diff --git a/Frontend/src/app/components/event-detail/event-detail.component.ts b/Frontend/src/app/components/event-detail/event-detail.component.ts
index c41269f..296a26c 100644
--- a/Frontend/src/app/components/event-detail/event-detail.component.ts
+++ b/Frontend/src/app/components/event-detail/event-detail.component.ts
@@ -64,7 +64,6 @@ export class EventDetailComponent implements OnInit {
             let cOld = '';
             let cNew = '';
             let cDetails = false;
-            let appendChange = true;
 
             if (change.is_deleted) {
                 cSummary = 'Deleted';
@@ -104,18 +103,16 @@ export class EventDetailComponent implements OnInit {
                 cNew = change.new_categories;
                 cDetails = true;
             } else {
-                appendChange = false;
+                cSummary = 'Internal change';
             }
 
-            if(appendChange) {
-                this.changeDetails.push({
-                    timestamp: cTs,
-                    summary: cSummary,
-                    oldVersion: cOld,
-                    newVersion: cNew,
-                    hasDetails: cDetails
-                });
-            }
+            this.changeDetails.push({
+                timestamp: cTs,
+                summary: cSummary,
+                oldVersion: cOld,
+                newVersion: cNew,
+                hasDetails: cDetails
+            });
 
             lastChange = change;
         }