Paddy
3ea9e630ed
Prep PR for the admin auth module (docs/plan-admin-auth.md step 1).
better-auth 1.7 ships ESM only, so the API moves off CommonJS:
- "type": "module", module nodenext, target ES2024, .js suffixes on all
relative imports, require('mariadb'|'cors') replaced by imports, and
export= packages (winston, app-root-path, bcrypt) consumed via default
imports. The logger now uses appRoot.path explicitly.
- TypeScript 5.9, @types/node 26, tslint removed. Node 26 pinned via
engines and .nvmrc (Plesk runs 26).
- Jest 28 + ts-jest replaced by vitest 5. Eight test files depend on
hoisted module mocks with static imports and resetModules + require,
which Jest's ESM mode does not support; vitest keeps them nearly
verbatim. Coverage via @vitest/coverage-v8 (lcov), Sonar generic report
via vitest-sonar-reporter, so sonar-project.properties is unchanged.
vitest.config.ts sets FEEDBACK_IP_SALT so the suite passes without a
local .env.
- dotenv 8 -> 16 and axios 0.24 -> 1.x: their old typings are not
resolvable under nodenext.
- autoCommit: false dropped from the pool configs; it is not a mariadb
connector option and was silently ignored.
tsc clean, 96/96 tests green, compiled app boots and serves /, /docs and
CORS under Node ESM.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
30 lines
1.1 KiB
TypeScript
30 lines
1.1 KiB
TypeScript
// Isolated from ratelimit.test.ts because it needs to control whether
|
|
// FEEDBACK_IP_SALT is present at module-load time, which a real dotenv.config()
|
|
// call would silently repopulate from the repo's .env file.
|
|
import {vi, describe, it, expect, afterEach} from 'vitest';
|
|
vi.mock('dotenv', () => ({config: vi.fn()}));
|
|
vi.mock('../../src/models/feedback/Feedback.db.js', () => ({
|
|
NachklangFeedbackDB: {getConnection: vi.fn()}
|
|
}));
|
|
|
|
describe('FEEDBACK_IP_SALT enforcement', () => {
|
|
const originalSalt = process.env.FEEDBACK_IP_SALT;
|
|
|
|
afterEach(() => {
|
|
process.env.FEEDBACK_IP_SALT = originalSalt;
|
|
vi.resetModules();
|
|
});
|
|
|
|
it('throws at import time when FEEDBACK_IP_SALT is unset, rather than silently hashing unsalted', async () => {
|
|
vi.resetModules();
|
|
delete process.env.FEEDBACK_IP_SALT;
|
|
await expect(import('../../src/models/feedback/feedback.ratelimit.js')).rejects.toThrow(/FEEDBACK_IP_SALT/);
|
|
});
|
|
|
|
it('does not throw when FEEDBACK_IP_SALT is set', async () => {
|
|
vi.resetModules();
|
|
process.env.FEEDBACK_IP_SALT = 'a-real-salt';
|
|
await expect(import('../../src/models/feedback/feedback.ratelimit.js')).resolves.toBeDefined();
|
|
});
|
|
});
|