3ea9e630ed
Prep PR for the admin auth module (docs/plan-admin-auth.md step 1).
better-auth 1.7 ships ESM only, so the API moves off CommonJS:
- "type": "module", module nodenext, target ES2024, .js suffixes on all
relative imports, require('mariadb'|'cors') replaced by imports, and
export= packages (winston, app-root-path, bcrypt) consumed via default
imports. The logger now uses appRoot.path explicitly.
- TypeScript 5.9, @types/node 26, tslint removed. Node 26 pinned via
engines and .nvmrc (Plesk runs 26).
- Jest 28 + ts-jest replaced by vitest 5. Eight test files depend on
hoisted module mocks with static imports and resetModules + require,
which Jest's ESM mode does not support; vitest keeps them nearly
verbatim. Coverage via @vitest/coverage-v8 (lcov), Sonar generic report
via vitest-sonar-reporter, so sonar-project.properties is unchanged.
vitest.config.ts sets FEEDBACK_IP_SALT so the suite passes without a
local .env.
- dotenv 8 -> 16 and axios 0.24 -> 1.x: their old typings are not
resolvable under nodenext.
- autoCommit: false dropped from the pool configs; it is not a mariadb
connector option and was silently ignored.
tsc clean, 96/96 tests green, compiled app boots and serves /, /docs and
CORS under Node ESM.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
117 lines
4.0 KiB
TypeScript
117 lines
4.0 KiB
TypeScript
// common.mail relays one email through the Salesforce org (see
|
|
// src/common/common.mail.ts). These tests mock the shared Salesforce client so
|
|
// no network is touched, and check: the payload shape, base64 attachment
|
|
// encoding, the attachment size cap, the retry-once-on-transient-failure
|
|
// behaviour, and that a delivery failure is swallowed (returns false, never
|
|
// throws).
|
|
|
|
import {vi, describe, it, expect, beforeEach, type Mock} from 'vitest';
|
|
vi.mock('../../src/common/salesforce.client.js');
|
|
vi.mock('../../src/middleware/logger.js', () => ({
|
|
__esModule: true,
|
|
default: {info: vi.fn(), warn: vi.fn(), error: vi.fn()}
|
|
}));
|
|
|
|
import {MailService} from '../../src/common/common.mail.js';
|
|
import {salesforceApexRestPost, salesforceEnabled} from '../../src/common/salesforce.client.js';
|
|
|
|
const mockPost = salesforceApexRestPost as Mock;
|
|
const mockEnabled = salesforceEnabled as Mock;
|
|
|
|
const httpError = (status: number, body?: any): any => {
|
|
const err: any = new Error('request failed with ' + status);
|
|
err.response = {status, data: body};
|
|
return err;
|
|
};
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
mockEnabled.mockReturnValue(true);
|
|
mockPost.mockResolvedValue({status: 'SENT'});
|
|
});
|
|
|
|
describe('MailService.sendMail', () => {
|
|
it('returns false without a callout when Salesforce is disabled', async () => {
|
|
mockEnabled.mockReturnValue(false);
|
|
|
|
const result = await MailService.sendMail('guest@example.com', 'Hi', 'Hallo');
|
|
|
|
expect(result).toBe(false);
|
|
expect(mockPost).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('posts the email to the Apex REST endpoint and returns true on success', async () => {
|
|
const result = await MailService.sendMail('guest@example.com', 'Bestätigung', 'Hallo', {html: '<p>Hallo</p>'});
|
|
|
|
expect(result).toBe(true);
|
|
expect(mockPost).toHaveBeenCalledWith('/services/apexrest/email/send', {
|
|
to: 'guest@example.com',
|
|
subject: 'Bestätigung',
|
|
textBody: 'Hallo',
|
|
htmlBody: '<p>Hallo</p>',
|
|
attachments: []
|
|
});
|
|
});
|
|
|
|
it('sends htmlBody as null when no HTML is given', async () => {
|
|
await MailService.sendMail('guest@example.com', 'Hi', 'Hallo');
|
|
|
|
expect(mockPost).toHaveBeenCalledWith('/services/apexrest/email/send', expect.objectContaining({htmlBody: null}));
|
|
});
|
|
|
|
it('base64-encodes attachments', async () => {
|
|
await MailService.sendMail('guest@example.com', 'Hi', 'Hallo', {
|
|
attachments: [{filename: 'konzert.ics', content: 'BEGIN:VCALENDAR', contentType: 'text/calendar'}]
|
|
});
|
|
|
|
expect(mockPost).toHaveBeenCalledWith(
|
|
'/services/apexrest/email/send',
|
|
expect.objectContaining({
|
|
attachments: [{
|
|
filename: 'konzert.ics',
|
|
contentType: 'text/calendar',
|
|
contentBase64: Buffer.from('BEGIN:VCALENDAR', 'utf-8').toString('base64')
|
|
}]
|
|
})
|
|
);
|
|
});
|
|
|
|
it('rejects an attachment over the size cap without sending', async () => {
|
|
const huge = Buffer.alloc(3 * 1024 * 1024 + 1);
|
|
|
|
const result = await MailService.sendMail('guest@example.com', 'Hi', 'Hallo', {
|
|
attachments: [{filename: 'big.pdf', content: huge}]
|
|
});
|
|
|
|
expect(result).toBe(false);
|
|
expect(mockPost).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('retries once on a 5xx and returns false when the retry also fails', async () => {
|
|
mockPost.mockRejectedValue(httpError(503));
|
|
|
|
const result = await MailService.sendMail('guest@example.com', 'Hi', 'Hallo');
|
|
|
|
expect(result).toBe(false);
|
|
expect(mockPost).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
it('retries once on a network error (no response) then succeeds', async () => {
|
|
mockPost.mockRejectedValueOnce(new Error('socket hang up')).mockResolvedValueOnce({status: 'SENT'});
|
|
|
|
const result = await MailService.sendMail('guest@example.com', 'Hi', 'Hallo');
|
|
|
|
expect(result).toBe(true);
|
|
expect(mockPost).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
it('does not retry on a 4xx (e.g. the 429 limit response) and returns false', async () => {
|
|
mockPost.mockRejectedValue(httpError(429, {errorCode: 'LIMIT_REACHED'}));
|
|
|
|
const result = await MailService.sendMail('guest@example.com', 'Hi', 'Hallo');
|
|
|
|
expect(result).toBe(false);
|
|
expect(mockPost).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|