Paddy
3ea9e630ed
Prep PR for the admin auth module (docs/plan-admin-auth.md step 1).
better-auth 1.7 ships ESM only, so the API moves off CommonJS:
- "type": "module", module nodenext, target ES2024, .js suffixes on all
relative imports, require('mariadb'|'cors') replaced by imports, and
export= packages (winston, app-root-path, bcrypt) consumed via default
imports. The logger now uses appRoot.path explicitly.
- TypeScript 5.9, @types/node 26, tslint removed. Node 26 pinned via
engines and .nvmrc (Plesk runs 26).
- Jest 28 + ts-jest replaced by vitest 5. Eight test files depend on
hoisted module mocks with static imports and resetModules + require,
which Jest's ESM mode does not support; vitest keeps them nearly
verbatim. Coverage via @vitest/coverage-v8 (lcov), Sonar generic report
via vitest-sonar-reporter, so sonar-project.properties is unchanged.
vitest.config.ts sets FEEDBACK_IP_SALT so the suite passes without a
local .env.
- dotenv 8 -> 16 and axios 0.24 -> 1.x: their old typings are not
resolvable under nodenext.
- autoCommit: false dropped from the pool configs; it is not a mariadb
connector option and was silently ignored.
tsc clean, 96/96 tests green, compiled app boots and serves /, /docs and
CORS under Node ESM.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
90 lines
3.1 KiB
TypeScript
90 lines
3.1 KiB
TypeScript
// resendRedemptionConfirmation rebuilds the confirmation email from stored
|
|
// redemption data and records the new outcome. Only the resend path is
|
|
// exercised here; the shared send/record logic is covered by
|
|
// confirmation-email.test.ts.
|
|
|
|
import {vi, describe, it, expect, beforeEach, type Mock} from 'vitest';
|
|
vi.mock('../../src/models/tickets/Tickets.db.js', () => ({
|
|
NachklangTicketsDB: {getConnection: vi.fn()}
|
|
}));
|
|
vi.mock('../../src/models/tickets/tickets.confirmation-email.js', () => ({
|
|
sendRedemptionConfirmation: vi.fn(),
|
|
recordConfirmationEmailResult: vi.fn()
|
|
}));
|
|
|
|
import {NachklangTicketsDB} from '../../src/models/tickets/Tickets.db.js';
|
|
import {recordConfirmationEmailResult, sendRedemptionConfirmation} from '../../src/models/tickets/tickets.confirmation-email.js';
|
|
import {resendRedemptionConfirmation} from '../../src/models/tickets/admin/redemptions.admin.service.js';
|
|
|
|
const mockGetConnection = NachklangTicketsDB.getConnection as Mock;
|
|
const mockSend = sendRedemptionConfirmation as Mock;
|
|
const mockRecord = recordConfirmationEmailResult as Mock;
|
|
|
|
const ACTIVE_ROW = {
|
|
redemption_id: 5,
|
|
code: 'ABC123',
|
|
event_id: 42,
|
|
status: 'ACTIVE',
|
|
contact_name: 'Erika Mustermann',
|
|
contact_email: 'erika@example.com',
|
|
contact_address: null,
|
|
guest_count: 2,
|
|
redeemed_at: new Date('2026-06-01T10:00:00Z'),
|
|
confirmation_email_status: 'FAILED'
|
|
};
|
|
|
|
// getRedemption issues: 1) SELECT redemptions, 2) SELECT redemption_guests
|
|
const connFor = (redemptionRows: any[], guestRows: any[] = []) => ({
|
|
query: vi
|
|
.fn()
|
|
.mockResolvedValueOnce(redemptionRows)
|
|
.mockResolvedValueOnce(guestRows),
|
|
end: vi.fn().mockResolvedValue(undefined)
|
|
});
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
mockSend.mockResolvedValue(true);
|
|
});
|
|
|
|
describe('resendRedemptionConfirmation', () => {
|
|
it('returns NOT_FOUND when the redemption does not exist', async () => {
|
|
mockGetConnection.mockResolvedValue(connFor([]));
|
|
|
|
expect(await resendRedemptionConfirmation(5)).toBe('NOT_FOUND');
|
|
expect(mockSend).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('returns NOT_ACTIVE for an undone redemption', async () => {
|
|
mockGetConnection.mockResolvedValue(connFor([{...ACTIVE_ROW, status: 'UNDONE'}]));
|
|
|
|
expect(await resendRedemptionConfirmation(5)).toBe('NOT_ACTIVE');
|
|
expect(mockSend).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('resends from the stored data and records SENT on success', async () => {
|
|
mockGetConnection.mockResolvedValue(connFor([ACTIVE_ROW], [{name: 'Erika Mustermann'}, {name: 'Hans Mustermann'}]));
|
|
|
|
const result = await resendRedemptionConfirmation(5);
|
|
|
|
expect(result).toBe('SENT');
|
|
expect(mockSend).toHaveBeenCalledWith({
|
|
eventId: 42,
|
|
contactName: 'Erika Mustermann',
|
|
contactEmail: 'erika@example.com',
|
|
guestNames: ['Erika Mustermann', 'Hans Mustermann']
|
|
});
|
|
expect(mockRecord).toHaveBeenCalledWith(5, true);
|
|
});
|
|
|
|
it('records FAILED and returns FAILED when the relay rejects the send', async () => {
|
|
mockGetConnection.mockResolvedValue(connFor([ACTIVE_ROW], [{name: 'Erika Mustermann'}]));
|
|
mockSend.mockResolvedValue(false);
|
|
|
|
const result = await resendRedemptionConfirmation(5);
|
|
|
|
expect(result).toBe('FAILED');
|
|
expect(mockRecord).toHaveBeenCalledWith(5, false);
|
|
});
|
|
});
|